Change in vdsm[master]: Add passwd command to vdsm-tool

agl at us.ibm.com agl at us.ibm.com
Fri May 25 12:47:51 UTC 2012


Adam Litke has posted comments on this change.

Change subject: Add passwd command to vdsm-tool
......................................................................


Patch Set 3: No score

(1 inline comment)

Removing -1 to encourage further review from others.

....................................................
File vdsm.spec.in
Line 364
Yes, I like that you moved the code into vdsm-tool.  But it seems you have also changed the package installation process.  Before your patch, the libvirt sasl password was set here during installation.  After your patch, it is never set.

--
To view, visit http://gerrit.ovirt.org/4528
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76b5aee4c2f11a7680c675c171ff35a463a70402
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Lei Li <lilei at linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list