Change in vdsm[master]: vdsm: [CpuPinning] support for cpuPinning

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Tue May 22 02:28:57 UTC 2012


Mark Wu has posted comments on this change.

Change subject: vdsm: [CpuPinning] support for cpuPinning
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 716:             cpuPinningStr = self.conf.get('smpCoresPerSocket')
I don't understand why you get cpu pinning string from vm.conf['smpCoresPerSocket'], which should be used to specify the core number of each socket. I think you need introduce a new field to store the pinning string.

Additionally, I suggest you add a pattern validation here. Perhaps it is already covered on ovirt engine side. But it's better to add it to vdsm too because vdsm could run in a standalone mode in future.

--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list