Change in vdsm[master]: vdsm: [CpuPinning] support for cpuPinning

smizrahi at redhat.com smizrahi at redhat.com
Mon May 21 20:44:10 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: vdsm: [CpuPinning] support for cpuPinning
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 716:             cpuPinningStr = self.conf.get('smpCoresPerSocket')
If you use get() it means you expect the key to might not exist an None to be returned.
There is no handling for that case in your code. Either use the [] operator or handle None.

--
To view, visit http://gerrit.ovirt.org/4630
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7016848d365d0e59454372461d66d167b100e7e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list