Change in vdsm[master]: Move prepare-vmchannel to supervdsm
danken at redhat.com
danken at redhat.com
Wed May 16 20:44:21 UTC 2012
Dan Kenigsberg has posted comments on this change.
Change subject: Move prepare-vmchannel to supervdsm
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/supervdsmServer.py
Line 126: channelPattern = re.compile('/var/lib/libvirt/qemu/channels/.+')
is this any better than .startswith()?
Line 128: raise Exception("Illegal vmchannel socket")
incorporate socketFile in error message, maybe?
--
To view, visit http://gerrit.ovirt.org/4242
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I92f8084af5d9418ddeb743efa3c43a81a555d369
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>
More information about the vdsm-patches
mailing list