Change in vdsm[master]: Move prepare-vmchannel to supervdsm

danken at redhat.com danken at redhat.com
Wed May 9 21:14:47 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Move prepare-vmchannel to supervdsm
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/supervdsmServer.py
Line 94:     def prepareVmChannel(self, socketFile):
that's two general. we do not want any part of Vdsm to be able to play with the mode of any file. The argument here should be the Vm id, from which the function deduces the file to mangle. Alternatively, it can do like what the bash script was doing: verify that socketFile =~ /var/lib/libvirt/qemu/channels/

--
To view, visit http://gerrit.ovirt.org/4242
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92f8084af5d9418ddeb743efa3c43a81a555d369
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list