Change in vdsm[master]: libvirtvm.py: Extend controller support to allow configuring...

hdegoede at redhat.com hdegoede at redhat.com
Sun May 6 11:31:47 UTC 2012


Hans De Goede has posted comments on this change.

Change subject: libvirtvm.py: Extend controller support to allow configuring USB controllers
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 866:                                   ['index', 'model', 'master', 'address'])
startport is not an attribute of the controller element itself, but an attribute of the master child element. Since master, like address is a child element its representation in the xmlrpc will be a dict. And like with address all name:value pairs in the dict will get set as attributes on the master child element.

Notice how the value of master is a dict  here:
devices='{type:controller,device:usb,model:ich9-uhci3,master:{startport:4},address:{...}}'

--
To view, visit http://gerrit.ovirt.org/4095
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4fd6bed73cfa67fd6b29d3c352aebc7c25cff5f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hans De Goede <hdegoede at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Hans De Goede <hdegoede at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list