Change in vdsm[master]: vdsClient.py: Allow specifying nested dicts for devices when...
hdegoede at redhat.com
hdegoede at redhat.com
Sun May 6 11:14:00 UTC 2012
Hans De Goede has posted comments on this change.
Change subject: vdsClient.py: Allow specifying nested dicts for devices when creating a vm
......................................................................
Patch Set 1: (5 inline comments)
....................................................
File vdsm_cli/vdsClient.py
Line 1387: spec = spec[1:]
Done.
Line 1394: d["index"] = int(d["index"])
You're right. I'm pretty sure I added this to avoid a backtrace inside vdsm which I was getting when a disk index was a string, but that likely then was an issue elsewhere in my very much WIP code back then. Removing this and sending a new iteration of my patches soon.
Line 1399: raise Exception("missing name value separator ':' in '%s'" % spec)
I'm trying to give a user readable error here, rather then causing an Exception the line below (when there is no ':', split will only return one value, where as a tupple of 2 values is needed).
Line 1420: d[name] = False
Same as with the index, I seemed to need this, now I now longer do will remove.
Line 1559: 'create' : ( serv.do_create,
Done.
--
To view, visit http://gerrit.ovirt.org/4094
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe4eb528684c1d2053cb9574d8f63bbbf0a03c23
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hans De Goede <hdegoede at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Hans De Goede <hdegoede at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
More information about the vdsm-patches
mailing list