Change in vdsm[master]: Implement Popen without forking back to python

danken at redhat.com danken at redhat.com
Wed May 2 16:15:56 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Implement Popen without forking back to python
......................................................................


Patch Set 9: I would prefer that you didn't submit this

(3 inline comments)

minor stuff, haven't looked at true code.

....................................................
File vdsm.spec.in
Line 539: %{_datadir}/%{vdsm_name}/storage/betterPopen/createprocess.so
not so good, as /usr/share is supposed to be shared by different archs. not that we support anything but x86_64, but  this is bound to pain some automatic checking tool such as "danken".

....................................................
File vdsm/storage/betterPopen/__init__.py
Line 1: import os
let's not infuriate our lawyers: state GPLness here, and in every new file you add.

Line 6: 
please repeat your commit message's nice docs here, for future casual browsers.

this module may interest folks outside vdsm, make them feel welcome ;-)

these apply to the c code, too.

--
To view, visit http://gerrit.ovirt.org/3944
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief4ae42eb57551d7f5893bf562da451a9c98f219
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list