Change in vdsm[master]: Collect more guest memory stats

danken at redhat.com danken at redhat.com
Wed May 2 15:56:28 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Collect more guest memory stats
......................................................................


Patch Set 2: Looks good to me, approved

Thanks!

Would you consider writing a unit test for _handleMessage()?

making the code testable may be a challenge, so this is not a hard req for this patch.

--
To view, visit http://gerrit.ovirt.org/3917
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I678210dac8c66eeb0360e58e5332de3218402463
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list