Change in vdsm[master]: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6

abaron at redhat.com abaron at redhat.com
Tue Mar 13 22:04:15 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................


Patch Set 1: I would prefer that you didn't submit this

Argh.  I didn't consider the F16 issue  when I asked Edu to simply support the new format (mea culpa, sorry).

Supporting both would require vdsm to check what LVM version is used and parse accordingly (if later on LVM remove 2 fields it should not be treated as the current set of 6 automatically).

Truncating would be based on the assumption that LVM preserved the first 6, is there any guarantee for that from LVM? I don't particularly like assumptions...

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list