Change in vdsm[master]: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6

danken at redhat.com danken at redhat.com
Tue Mar 13 19:40:28 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: fix LV_ATTR_BITS for use with lvm 2.02.95(2)-RHEL6
......................................................................


Patch Set 1: I would prefer that you didn't submit this

this would explode when run on older versions of lvm, that has only 6 attrs.

you should either require the newer lvm2 version (and make vdsm fail to install on Fedora 16), or make Vdsm run with both versions of lvm.

(brute force fix is to chop sAttr according to len(attrMask) in lvm._attr2NamedTuple.

--
To view, visit http://gerrit.ovirt.org/2785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I634f84f9f816f4583adbe3c53c88d882a9b339c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list