Change in vdsm[master]: A new method to read from VMs' channels.

ghammer at redhat.com ghammer at redhat.com
Thu Mar 8 07:52:53 UTC 2012


Gal Hammer has posted comments on this change.

Change subject: A new method to read from VMs' channels.
......................................................................


Patch Set 10: (5 inline comments)

....................................................
File vdsm/vmChannels.py
Line 65:                     self.log.exception("Exception on timeout callback.")
No need. The log.exception include the back trace.

Line 93:         try:
Done

Line 108:                 if obj['connect_cb'](obj['opaque']) == True:
Done

Line 115:                 self.log.exception("Exception on connect callback.")
The log.exception include the back trace. Same as exc_info=True, but much nicer (to my opinion).

Line 148:         try:
Done

--
To view, visit http://gerrit.ovirt.org/869
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I687a22a3fba6c1d2b42e837c5f2024aee0a98bdc
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list