Change in vdsm[master]: Added blkid tool support in supervdsm.

danken at redhat.com danken at redhat.com
Thu Mar 8 00:52:00 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Added blkid tool support in supervdsm.
......................................................................


Patch Set 5: I would prefer that you didn't submit this

(1 inline comment)

I know this was not your original intention, but if your doing this, let's do it correctly until completion.

....................................................
File vdsm/clientIF.py
Line 164:             return svdsm.getProxy().getDeviceByUuid(uuid)
actually, this use case does not need root user.

--
To view, visit http://gerrit.ovirt.org/2185
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9ad51df4f4b98e2aff5db1d9c02512045977a60
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list