Change in vdsm[master]: Fixing pep8 in vdsm/define.py

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Tue Jun 5 03:32:59 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: Fixing pep8 in vdsm/define.py
......................................................................


Patch Set 2: Verified

The changes pass vdsm test.

pydiff report:

$ pydiff define*.py
2 difference(s)
first file: defineo.py
second file: define.py

((28, 'Error creating the requested virtual machine'),
 (44, 'Error creating the requested VM'))

((33, 'Not enough free memory to create virtual machine'),
 (61, 'Not enough free memory to create VM'))


This means the only change in syntax logic is changing the string. If this change is acceptable, then the patch does not break anything.

--
To view, visit http://gerrit.ovirt.org/4536
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f7d360ccac8af010b3e55f88e1614f73dae7461
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list