Change in vdsm[master]: clean PEP 8 problems in vdsm/clientIF.py

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Tue Jun 5 03:07:30 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: clean PEP 8 problems in vdsm/clientIF.py
......................................................................


Patch Set 1: Verified

The changes pass vdsm test.

I examine the old version and the new version with pydiff (https://github.com/edwardbadboy/pydiff). It reports some logic changes in code, but those are all changes of 'someDict.has_key(someKey)' to 'somKey in someDict'.

pydiff report:

$ pydiff clientIF*.py
5 difference(s)
first file: clientIF_old.py
second file: clientIF.py

((224,
  "CallFunc(Getattr(Name('drive'), 'has_key'), [Const('GUID')], None, None)"),
 (229, "Compare(Const('GUID'), [('in', Name('drive'))])"))

((235,
  "CallFunc(Getattr(Name('drive'), 'has_key'), [Const('UUID')], None, None)"),
 (240, "Compare(Const('UUID'), [('in', Name('drive'))])"))

((238,
  "CallFunc(Getattr(Name('drive'), 'has_key'), [Const('specParams')], None, None)"),
 (243, "Compare(Const('specParams'), [('in', Name('drive'))])"))

((239,
  "CallFunc(Getattr(Subscript(Name('drive'), 'OP_APPLY', [Const('specParams')]), 'has_key'), [Const('vmPayload')], None, None)"),
 (244,
  "Compare(Const('vmPayload'), [('in', Subscript(Name('drive'), 'OP_APPLY', [Const('specParams')]))])"))

((251,
  "CallFunc(Getattr(Name('drive'), 'has_key'), [Const('path')], None, None)"),
 (257, "Compare(Const('path'), [('in', Name('drive'))])"))

--
To view, visit http://gerrit.ovirt.org/4802
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f912dd53f84b57f09665edb80c99768006e725c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list