Change in vdsm[master]: add VdsmConfig.py for support writing comment to config file

danken at redhat.com danken at redhat.com
Sat Jun 2 22:10:34 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: add VdsmConfig.py for support writing comment to config file
......................................................................


Patch Set 1:

have you seen my inline comments?

could you spell out your motivation in the commit message?

VdsmConfig.py should be called CommentKeepingConfigParser or a better name - it has nothing to do with Vdsm.

Please note that it may be more cost-effective to generate MONITORED_PATHS in build time, over maintaining this class.

--
To view, visit http://gerrit.ovirt.org/4826
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06d8d23e1d1f12b880ae71e2c978efcfece8001a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list