Change in vdsm[master]: fix can't get ssl opt in vdsm sos plugin

danken at redhat.com danken at redhat.com
Sat Jun 2 21:54:12 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: fix can't get ssl opt in vdsm sos plugin
......................................................................


Patch Set 2: I would prefer that you didn't submit this

Would you please add a functional test, verifying that now 

 sosreport -o vdsmd

works.

I was about to +1 your patch, but come to think of it - your change may harm scripts expecting -o vdsm. Note that the current code should work if /etc/vdsm/vdsm.conf has ssl set explicitly. Could you find a way to hack around the problem (remove '' from sys.path just before from vdsm.config ??) without changing the module name?

In the worse case, you can

 try:
   ssl = getboolean(ssl)
 excpet EEEE:
   ssl = True

I count it as bad, since it duplicates the default ssl value from vdsm.spec.

--
To view, visit http://gerrit.ovirt.org/4349
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbbc9a10202f191d0754bfae5c3f876b6c53a560
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list