Change in vdsm[master]: BZ#839312 - Use cp to copy sparse files to ensure they remai...

ykaplan at redhat.com ykaplan at redhat.com
Wed Jul 18 13:57:29 UTC 2012


Yeela Kaplan has posted comments on this change.

Change subject: BZ#839312 - Use cp to copy sparse files to ensure they remain sparse.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/image.py
Line 584:                     if isinstance(dstVol, fileVolume.FileVolume) and dstVol.getType() == volume.SPARSE_VOL:
You should check first, I understood that qemu-img might introduce some problems with this code and that is why dd was used in the first place.

--
To view, visit http://gerrit.ovirt.org/6160
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff138110bd0990cd7d41481b933fb6776a3fcdaf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Nigel Jones <nigjones at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list