Change in vdsm[master]: BZ#839312 - Use cp to copy sparse files to ensure they remai...

lyarwood at redhat.com lyarwood at redhat.com
Wed Jul 18 13:22:56 UTC 2012


Lee Yarwood has posted comments on this change.

Change subject: BZ#839312 - Use cp to copy sparse files to ensure they remain sparse.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/image.py
Line 584:                     if isinstance(dstVol, fileVolume.FileVolume) and dstVol.getType() == volume.SPARSE_VOL:
Yes that's a valid case, for example if the export domain is block (only possible with older downstream versions) and the data is file based. AFAIK cp will provide a block by block copy of the LV into a file.

I hadn't thought of using qemu-img at the time of writing this patch but a number of people have since highlighted it to me. I'll rewrite this change to use qemu-img instead, removing this horrid check and verify against the above use case.

Thanks,

Lee

--
To view, visit http://gerrit.ovirt.org/6160
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff138110bd0990cd7d41481b933fb6776a3fcdaf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Nigel Jones <nigjones at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list