Change in vdsm[master]: Basic tests for the tc module

roman at fenkhuber.at roman at fenkhuber.at
Tue Jul 17 16:05:16 UTC 2012


Roman Fenkhuber has posted comments on this change.

Change subject: Basic tests for the tc module
......................................................................


Patch Set 3: (2 inline comments)

....................................................
File tests/tcTests.py
Line 83: def _listenOnDevice(fd):
I will do that, but as the read is not in nonblocking mode and it only mirrors all ethernet frames it gets, I don't think that this is a tight loop. Am I wrong?

Line 172:         self.tap0.addDevice("192.168.3.1/24")
Regarding your worries about the assigned IP address, I will change this line to
 
 self.tap0.addDevice().

tap0 does not really need its own address. When I do not assign an IP address the test will not mess around with the routing tables.

--
To view, visit http://gerrit.ovirt.org/6225
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee9437d1b5a96b3896df157f13888485ae7292d2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Fenkhuber <roman at fenkhuber.at>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Roman Fenkhuber <roman at fenkhuber.at>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list