Change in vdsm[master]: Basic tests for the tc module

danken at redhat.com danken at redhat.com
Mon Jul 16 14:43:57 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Basic tests for the tc module
......................................................................


Patch Set 3: (2 inline comments)

....................................................
File tests/tcTests.py
Line 83: def _listenOnDevice(fd):
so at least sleep between reads

Line 173:         self.tap0.arpProxyFor("192.168.3.2")
oh, I wonder if mirroring only ip was intentional. Shahar, any clue?

in any way, this is not for this patch to fix. just document the reason for adding a tap device with its ip address.

Thanks!

--
To view, visit http://gerrit.ovirt.org/6225
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee9437d1b5a96b3896df157f13888485ae7292d2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Fenkhuber <roman at fenkhuber.at>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Roman Fenkhuber <roman at fenkhuber.at>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list