Change in vdsm[master]: Fix remotePath comparison in getStorageDomainsList

ilvovsky at redhat.com ilvovsky at redhat.com
Sun Feb 19 13:15:51 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: Fix remotePath comparison in getStorageDomainsList
......................................................................


Patch Set 7: Looks good to me, but someone else must approve

(1 inline comment)

comment inside

....................................................
File vdsm/storage/hsm.py
Line 2119:                 if remotePath and remotePath != dom.getRemotePath():
Actually, this particular fix is right. It looks like this code was broken for the long time (just no one use this call with 'remotePath' parameter).
My only problem is that it's still broken for iSCSI domains (because getRemotePath doesn't exists there), but because this is not a regression we can push it.

--
To view, visit http://gerrit.ovirt.org/1244
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50c856f0a612b27672a5c6ccda877979455b00f5
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list