Change in vdsm[master]: Refactor upgrade process to facilitate repository format con...
abaron at redhat.com
abaron at redhat.com
Sun Feb 19 09:49:11 UTC 2012
Ayal Baron has posted comments on this change.
Change subject: Refactor upgrade process to facilitate repository format conversions
......................................................................
Patch Set 19: I would prefer that you didn't submit this
(11 inline comments)
....................................................
File vdsm/storage/repositoryConverter.py
Line 3: CFEAT_LIVE_UPGRADE = "live upgrade"
cfeat?
Line 5: def convert_LegacyVersionUpgrade(domain, targetFormat):
why underscore?
Line 9: return (currentFormat, tagetFormat) in CONVERTERS
%s/taget/target/g
Line 16: _getConverter(currentFormat, targetFormat)
why both this and conversionAvailable?
....................................................
File vdsm/storage/sdc.py
Line 39: """ Used so we can change domain objects (convert format) on the fly
s/.*/Keeps domain references valid even when underlying domain object changes (due to format conversion for example)./
Line 46: #FIXME : this objects holding callbacks will not be updated
s/this//
Line 47: # this is currently not needed but fix in case it does
s/does/is/
....................................................
File vdsm/storage/sd.py
Line 143: if version not in (0, 2):
why not SUPPORTED_DOMAIN_FORMATS?
Line 621: def getFormat(self):
why keep 'getVersion'? int/str semantics?
....................................................
File vdsm/storage/sp.py
Line 195: self._convertMemberDomain(domain, targetPoolVersion)
I'm assuming that if "currDomVersion > targetPoolVersion" then there will be no converter available?
Line 415: if not repositoryConverter.canConvert(domainFormat, targetDomainFormat):
why aren't these validations inside repositoryConverter.convert?
--
To view, visit http://gerrit.ovirt.org/193
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b036d244f3cf5b0adda129b44be5cff473dc9b7
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
More information about the vdsm-patches
mailing list