Change in vdsm[master]: BZ#790014 Fix multiple issues in detachSD

abaron at redhat.com abaron at redhat.com
Thu Feb 16 12:25:03 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: BZ#790014 Fix multiple issues in detachSD
......................................................................


Patch Set 8: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 955:         self.validateAttachedDomain(dom, domStatuses)
Actually I don't want this check.
If user initiated forcedDetachSd then running detachSD after the domain is visible again will fail to clear the back link from the domain to the pool.  Without this test the above would succeed.  Important thing is that we remove a specific pool back link (the one we're managing) so it's legal (albeit a bit unsafe)

--
To view, visit http://gerrit.ovirt.org/1876
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04a7c16df86b828c514daab34f21e352919217f9
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list