Change in vdsm[master]: BZ#790014 Fix multiple issues in detachSD

abaron at redhat.com abaron at redhat.com
Thu Feb 16 10:30:25 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: BZ#790014 Fix multiple issues in detachSD
......................................................................


Patch Set 5: (3 inline comments)

....................................................
File vdsm/storage/sp.py
Line 960:         detachingISO = dom.isISO()
My bad, shouldn't review when I'm tired.
I didn't notice that it is used twice (so metadata would be fetched twice which is wrong)

Line 1043:                     return
My bad, shouldn't review when I'm tired.

Line 1832:         self.stopSpm(force=True)
Fede you're right that force=True doesn't seem right

--
To view, visit http://gerrit.ovirt.org/1876
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04a7c16df86b828c514daab34f21e352919217f9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list