Change in vdsm[master]: fix TypeError of _eqSplit in vdsClient.py

danken at redhat.com danken at redhat.com
Thu Aug 30 22:05:38 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: fix TypeError of _eqSplit in vdsClient.py
......................................................................


fix TypeError of _eqSplit in vdsClient.py

if the arg is string 'xyz', the _eqSplit will into the 'else'
branch. and then k = ['xyz']. but list type can not be a hash key.
TypeError will come up.

throw a Exception to report this case, it is more clear what has
happended.

Change-Id: I98b5573499adaa1b64f8343b445cc16df8f60f3d
Signed-off-by: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
---
M vdsm_cli/vdsClient.py
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7200
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I98b5573499adaa1b64f8343b445cc16df8f60f3d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list