Change in vdsm[master]: Enable fake_kvm_support on hosts without hardware VT support...

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Wed Aug 15 03:45:54 UTC 2012


Mark Wu has posted comments on this change.

Change subject: Enable fake_kvm_support on hosts without hardware VT support automatically
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm.spec.in
Line 527: 
Line 528: %post hook-faqemu
Line 529: cat /proc/cpuinfo | grep -q "vmx \| svm"
Line 530: vt_supported=$?
Line 531: if [ $vt_supported -ne 0 ]; then
Sorry, I can't see why people disable fake_kvm_support explicitly on a host withou vt capability.  I assume that people want to use fake kvm if he installs the package. Even if he installs it unintentionally, the override should be safe. Please let me know any case I am not taking into consideration.  Thanks!
Line 532:     /usr/share/vdsm/set-conf-item /etc/vdsm/vdsm.conf vars fake_kvm_support true
Line 533: fi
Line 534: 
Line 535: %files


--
To view, visit http://gerrit.ovirt.org/6062
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76216ada10919b5e04e876d23fb9bea39859474c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list