Change in vdsm[master]: add simple VM creation functional test

deepakcs at linux.vnet.ibm.com deepakcs at linux.vnet.ibm.com
Wed Aug 22 11:23:01 UTC 2012


Deepak C Shetty has posted comments on this change.

Change subject: add simple VM creation functional test
......................................................................


Patch Set 1: No score

(2 inline comments)

....................................................
File tests/functional/vmTests.py
Line 40:         kernelPath = "/boot/vmlinuz-" + kernelVer
Line 41:         initramfsPath = "/boot/initramfs-%s.img" % kernelVer
Line 42:         vmid = str(uuid.uuid4())
Line 43:         conf = {'acpiEnable': 'True',
Line 44:                 'display': 'vnc',
My point is.. why add display at all ? How does it help in the functional test ? If it does.. then there are many other params which also needs to be added, and it will be a whole lot of combinational stuff possible.
Line 45:                 'initrd': initramfsPath,
Line 46:                 'kernel': kernelPath,
Line 47:                 # Fedora uses dracut to create initramfs. The following
Line 48:                 # arguments will be interpreted by init scripts created by


Line 72:                 time.sleep(1)
Line 73:         except Exception:
Line 74:             raise
Line 75:         finally:
Line 76:             assertVdsOK(self.s.destroy(vmid))
IIUC if its in wierd state, it will still show up in 'vmList' so it will get destroyed.
If its not in the 'vmList' means it wasn't instantiated at all.. 

Experts on the list can verify this.
Line 77: 
Line 78:     def isVMUp(self, vmid):
Line 79:         vmList = assertVdsOK(self.s.list())['vmList']
Line 80:         for vm in vmList:


--
To view, visit http://gerrit.ovirt.org/7396
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0d86ce20a547ef809d5407fe12d6ade474c4d2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list