Change in vdsm[master]: add simple VM creation functional test
michal.skrivanek at redhat.com
michal.skrivanek at redhat.com
Wed Aug 22 11:16:36 UTC 2012
Michal Skrivanek has posted comments on this change.
Change subject: add simple VM creation functional test
......................................................................
Patch Set 1: No score
(1 inline comment)
....................................................
File tests/functional/vmTests.py
Line 72: time.sleep(1)
Line 73: except Exception:
Line 74: raise
Line 75: finally:
Line 76: assertVdsOK(self.s.destroy(vmid))
isn't it better to try to destroy it just in case it's in some weird state. To not affect the other tests.
The exception and failure will anyway be there.
Line 77:
Line 78: def isVMUp(self, vmid):
Line 79: vmList = assertVdsOK(self.s.list())['vmList']
Line 80: for vm in vmList:
--
To view, visit http://gerrit.ovirt.org/7396
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0d86ce20a547ef809d5407fe12d6ade474c4d2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list