Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

abaron at redhat.com abaron at redhat.com
Mon Apr 30 11:53:24 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File vdsm/storage/fileSD.py
Line 273:                         if imgUUID in vPath)) > 1:
Ok, I understand why the code works, the comment however is totally misleading.
The comment should be something like:
Template volumes are hard linked in every image directory which is derived from that template, therefore:
1. a template volume which is in use will appear at least twice (in the template image dir and in the derived image dir)
2. Any volume which appears more than once in the dir tree is by definition a template volume
3. Any image which has more than 1 volume is not a template image
Therefore if imgUUID appears in more than one path then it is not a template

--
To view, visit http://gerrit.ovirt.org/3462
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7eccf5ca100bd354aa09208ca60bb112fb697063
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list