Change in vdsm[master]: BZ#788640 - Refactor Pool.deleteImage()

ilvovsky at redhat.com ilvovsky at redhat.com
Mon Apr 30 08:18:54 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: BZ#788640 - Refactor Pool.deleteImage()
......................................................................


Patch Set 7: Looks good to me, but someone else must approve

(3 inline comments)

looks fine in generally, only minor comments.
Fix it only if you will resend the patch

....................................................
File vdsm/storage/sp.py
Line 1712:         :param postZero: ?
If you already touch this.

bool, not '?'

Line 1722:         imgsByVol = dict((k, v) for k, v in allVols.iteritems() if imgUUID in v.imgs)
grrr, you love this  k,v   gibberish.
you promissed me better names.

Line 1737:             # TODO: Lock the template, reload allVols.
Don't forget to do this

--
To view, visit http://gerrit.ovirt.org/3464
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbc1397c69c7ffa835abe0747b6573d56bb9d74e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list