Change in vdsm[master]: Collect more guest memory stats
danken at redhat.com
danken at redhat.com
Sun Apr 29 12:34:46 UTC 2012
Dan Kenigsberg has posted comments on this change.
Change subject: Collect more guest memory stats
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File vdsm/guestIF.py
Line 104: # 'mem_total', 'mem_free', 'mem_unused', 'swap_in', 'swap_out',
mem_free? mem_unused?
what is the difference? (maybe I should have asked it on the ovirt-guest-agent patch)
Line 111: v = _filterXmlChars(str(v))
why's the conversion to str() here, btw?
(I hate "str" since it explodes on Chinese unicode input)
--
To view, visit http://gerrit.ovirt.org/3917
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I678210dac8c66eeb0360e58e5332de3218402463
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
More information about the vdsm-patches
mailing list