Change in vdsm[master]: Collect more guest memory stats

danken at redhat.com danken at redhat.com
Thu Apr 26 18:57:52 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Collect more guest memory stats
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
Commit Message
Line 11: vdsm to collect the memory stats.
thanks for the link, I was not aware of these additions.

Would you document here what are the expected keys, and the type and units of the values? In particular, note that xmlrpc's int is limited to 2G.

....................................................
File vdsm/guestIF.py
Line 105:                     self.guestInfo['memoryStats'][k] = int(v)
you must _filterXmlChars(k), or an evil guest can break xmlrpc

--
To view, visit http://gerrit.ovirt.org/3917
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I678210dac8c66eeb0360e58e5332de3218402463
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list