Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

danken at redhat.com danken at redhat.com
Wed Apr 25 14:38:02 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo
......................................................................


Patch Set 8: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/netinfo.py
Line 143:     netmask_hex = ((1L<<netmask)-1)<<(32-netmask)
could you split this to a new function? it begs for a unit test...

--
To view, visit http://gerrit.ovirt.org/3361
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Naori <davidnaori3 at gmail.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Lei Li <lilei at linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list