Change in vdsm[master]: replace ifconfig cmdline with ethtool and sysfs in netinfo

davidnaori3 at gmail.com davidnaori3 at gmail.com
Tue Apr 24 09:33:45 UTC 2012


David Naori has posted comments on this change.

Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo
......................................................................


Patch Set 7: Fails

(1 inline comment)

....................................................
File vdsm/netinfo.py
Line 143:     return intToAddress((1L<<netmask)-1)
>>> intToAddress((1L<<27)-1)
'255.255.255.7'

should be 255.255.255.224

--
To view, visit http://gerrit.ovirt.org/3361
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Naori <davidnaori3 at gmail.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Lei Li <lilei at linux.vnet.ibm.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list