Change in vdsm[master]: [WIP] Added blockSD.getImageMap().

ewarszaw at redhat.com ewarszaw at redhat.com
Sun Apr 15 13:46:34 UTC 2012


Eduardo has posted comments on this change.

Change subject: [WIP] Added blockSD.getImageMap().
......................................................................


Patch Set 1: (6 inline comments)

....................................................
File vdsm/storage/blockSD.py
Line 60: BlockSDWalk = namedtuple("BlockSDWalk", "template, chain")
You are very right! We need a better name but I don't know which it is.
Suggestions will be welcome.

Line 139:                 vols[lv.name] = BlockSDVol(lv.name, image, parent)
We are creaing a dict with the lvName as key. Later we will search by this key but is more comfortable to have the complete tuple as value.
May be we will change it later.

Line 148: def getImageMap(sdUUID):
As before bad name. Suggestions are welcome again.
This is not a domain map, is an image map of the domain.

Line 149:     def getChain(leaf):
Yes, I know. Hopefully the former will disappear soon.
There are in different classes although.

Line 157:         metadata.
I don't think that you are the only one. ;)

....................................................
File vdsm/storage/fileSD.py
Line 258:         return volumes
Rebase issue.
It's corrected.

--
To view, visit http://gerrit.ovirt.org/3462
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7eccf5ca100bd354aa09208ca60bb112fb697063
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list