Change in vdsm[master]: [WIP] Refactor Pool.deleteImage()
ilvovsky at redhat.com
ilvovsky at redhat.com
Thu Apr 12 08:57:32 UTC 2012
Igor Lvovsky has posted comments on this change.
Change subject: [WIP] Refactor Pool.deleteImage()
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/storage/sp.py
Line 1701: Assumed here that you have a name lock on imgUUID.
Why you didn't take the lock instead 'assume' it ?
Line 1715: if sdDom.isBackup():
Maybe I missing something, but where is a non-Backup case ?
Line 1719: # 2) if regular image dependent on fake remove image and fake
remove fake only if no more images dependes it
--
To view, visit http://gerrit.ovirt.org/3464
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbc1397c69c7ffa835abe0747b6573d56bb9d74e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
More information about the vdsm-patches
mailing list