Change in vdsm[master]: Make ClusterLock stateless

abaron at redhat.com abaron at redhat.com
Thu Apr 12 20:34:57 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: Make ClusterLock stateless
......................................................................


Patch Set 2: (1 inline comment)

I can't justify a -1 but I really don't like this way of verifying that it's locked.

....................................................
File vdsm/storage/safelease.py
Line 148:             return False
I wonder if it wouldn't be safer, faster and less error prone just to read the lease and compare host id and timestamp...
I can't say I like the above.

--
To view, visit http://gerrit.ovirt.org/3497
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie50f5fa79220bc9c0c5e35187415c7ff26c6dd28
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list