Change in vdsm[master]: Add persistentDictTests

abaron at redhat.com abaron at redhat.com
Thu Apr 12 20:23:39 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: Add persistentDictTests
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File tests/persistentDictTests.py
Line 29:                            # (C) Valve - Portal 2
is it legal to put these quotes here? or is it copyright infringement?

Line 60:                'he thought to himself, "where the worst type of women"'
s/where/were/
Are you quoting from memory? because I think you are not true to the source here.

Line 65:     def testFaileNestedTransaction(self):
testFaile"d"?

--
To view, visit http://gerrit.ovirt.org/3496
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib00d930051341dce6f1a986ac44cf0690b97c000
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list