Change in vdsm[master]: Compare Drive according to its name during lvextend
ewarszaw at redhat.com
ewarszaw at redhat.com
Mon Apr 9 15:24:41 UTC 2012
Eduardo has posted comments on this change.
Change subject: Compare Drive according to its name during lvextend
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/vm.py
Line 760: for d in self._devices[DISK_DEVICES]:
Assert that the actual 4 instances of this for loop can't be broken in the same way.
Line 761: if d.name != drive['name']: continue
Please continue statement in a separate line
--
To view, visit http://gerrit.ovirt.org/3391
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6ea950f8f9071f903ffaba85d7f84d9d12e8d5d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
More information about the vdsm-patches
mailing list