Change in vdsm[master]: Compare Drive according to its name during lvextend

danken at redhat.com danken at redhat.com
Mon Apr 9 14:43:45 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Compare Drive according to its name during lvextend
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(2 inline comments)

....................................................
Commit Message
Line 7: Compare Drive according to its name during lvextend
could you explain the problem you are solving now? (well, I know from irc, but still)

....................................................
File vdsm/vm.py
Line 762:             self._refreshLV(drive['domainID'], drive['poolID'],
blechs, we use drive['domainID] here, and d.domainID a line below. that's so ugly (but unrelated to this patch).

--
To view, visit http://gerrit.ovirt.org/3391
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6ea950f8f9071f903ffaba85d7f84d9d12e8d5d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list