Change in vdsm[master]: replace external ifconfig cmdline with ioctl/socket and sysf...

mhuntxu at gmail.com mhuntxu at gmail.com
Mon Apr 9 03:55:39 UTC 2012


Hunt Xu has posted comments on this change.

Change subject: replace external ifconfig cmdline with ioctl/socket and sysfs in netinfo
......................................................................


Patch Set 2: Verified

@Dan, I did consider the use of python-ethtool before I use ioctl directly. However, AFAIK, not all the distributions provide this module in their official software repository(not in Debian, Archlinux, Gentoo), so I'm just trying to prevent new dependency which couldn't be easily satisfied on many other distributions.

--
To view, visit http://gerrit.ovirt.org/3361
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu at gmail.com>


More information about the vdsm-patches mailing list