Change in vdsm[master]: replace extern ifconfig commandline with ioctl/socket and sy...

danken at redhat.com danken at redhat.com
Sat Apr 7 10:53:02 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: replace extern ifconfig commandline with ioctl/socket and sysfs in netinfo
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

Thanks for catching this issue!

Please add yourself as an AUTHOR.

However, I would prefer if this can be done via the python-ethtool module, instead direct ioctl calls.

....................................................
File vdsm/netinfo.py
Line 22: import fcntl, socket, struct
to make pep8 happy, split.

Line 39: IFREQ_SIZE = 40
this constant is not public, right?
let's call it _IFREQ_SIZE then.

Line 134:     ifreq = struct.pack('%d''s' % IFREQ_SIZE, dev[:16])
is the double single quotes intentional?

--
To view, visit http://gerrit.ovirt.org/3361
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list