Change in vdsm[master]: Integrate nosetests to vdsm testing

smizrahi at redhat.com smizrahi at redhat.com
Thu Apr 5 14:56:04 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: Integrate nosetests to vdsm testing
......................................................................


Patch Set 7: (2 inline comments)

....................................................
File tests/run_tests.sh.in
Line 2: PYTHONPATH="@builddir@/vdsm:@top_srcdir@/vdsm" @PYTHON@ @top_srcdir@/tests/testrunner.py $@
I hate files which need an ".in" suffix. I'd rather them being as small and static as possible.

....................................................
File tests/testrunner.py
Line 51: class VdsmTestResult(result.TextTestResult):
1. This class is meant to be overriden so it's not  like I'm doing something awful.
2. Build system integration is done through plugins and this doesn't interrupt it. just run with --with-xunit
3. I'm not only putting colors, I'm making the output skimmable also through spacing and filtering. Try commenting lines 131-135 and tell me if you find what tests failed. Then for extra points ramp up the verbosity level (-v) and then tell me if it's even comprehensible where a test starts and ends not to mention what the results was.

--
To view, visit http://gerrit.ovirt.org/3257
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c8d761ac0c03adf25324ea04e948b98faa82e39
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list