Change in vdsm[master]: Integrate nosetests to vdsm testing

fsimonce at redhat.com fsimonce at redhat.com
Thu Apr 5 14:06:03 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: Integrate nosetests to vdsm testing
......................................................................


Patch Set 7: I would prefer that you didn't submit this

(2 inline comments)

Could you try to get rid of the bash script and eventually split the color code out so that it can be reviewed separately? Thanks!

....................................................
File tests/run_tests.sh.in
Line 2: PYTHONPATH="@builddir@/vdsm:@top_srcdir@/vdsm" @PYTHON@ @top_srcdir@/tests/testrunner.py $@
Maybe we can try to rename testrunner.py to run_tests and try to append these paths there. (So that we can get rid of this bash script)

....................................................
File tests/testrunner.py
Line 51: class VdsmTestResult(result.TextTestResult):
I'm not really happy to maintain this code just to have a beautiful output. Maybe this is more relevant to upstream nosetests. If for some reason we'll need a different output for the tests (xml so that it can be plugged into a build infrastructure, etc...) we can do it elsewhere. I just don't feel that this is related/relevant to what we do. If this is helpful to you it could live in your tree eventually.

--
To view, visit http://gerrit.ovirt.org/3257
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c8d761ac0c03adf25324ea04e948b98faa82e39
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list