Change in vdsm[master]: BZ#773210 - Avoid infinite loop when delete volume failed du...

Eduardo ewarszaw at redhat.com
Thu Apr 5 07:24:02 UTC 2012


Eduardo has posted comments on this change.

Change subject: BZ#773210 - Avoid infinite loop when delete volume failed during the merge
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File vdsm/storage/image.py
Line 964:             except Exception:
Please catch the proper Exception, StorageException at least.
If catched, mark the volume as failed and FF to the next volume
Later retry a _finite_ number of times the failed volumes.

Line 969:                 time.sleep(10)
Nu, VeEmet!

--
To view, visit http://gerrit.ovirt.org/987
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1368141fb240c9ca4e3fb3cfad04f88312cc46b5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list