Change in vdsm[master]: fix masterVersion 0 err when connecting storage pool

lvroyce at linux.vnet.ibm.com lvroyce at linux.vnet.ibm.com
Thu Apr 5 03:04:27 UTC 2012


Royce Lv has posted comments on this change.

Change subject: fix masterVersion 0 err when connecting storage pool
......................................................................


Patch Set 2:

We check masterver 0 is because:
1.we have plan to support single host rest-api and have vdsm rest-api on the way,it means bypass vdsClient to call API.py directly(actually this is found when testing in such case)

2.as constants.py mentioned,
DOMAIN_VERSIONS = (0, 2, 3)
SUPPORTED_DOMAIN_VERSIONS = DOMAIN_VERSIONS
the default domain version -1 makes people confused because we don't support -1 explicitly,but support master version 0.

3.vdsclient is just a shell but api.py is in sdk layer, in order to isolate errors, different layers should not depend on(trust) other layer's input as default,instead,they should check the input and do the right thing.

Does it make sense?

--
To view, visit http://gerrit.ovirt.org/2679
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7228bd340a4281400e16c26b311d9945dd5ce597
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list