Change in vdsm[master]: BZ#736034 - Add metadataignore switch to pvcreate.

Haim Ateya hateya at redhat.com
Mon Sep 19 11:16:07 UTC 2011


Haim Ateya has posted comments on this change.

Change subject: BZ#736034 - Add metadataignore switch to pvcreate.
......................................................................


Patch Set 4: Fails

(1 inline comment)

please fix metdacopies to metadatacopies.

....................................................
File vdsm/storage/lvm.py
Line 704: def _initpvs(devices, metadataSize):
Line 705:     devices = _normalizeargs(devices)
Line 706:     # Size for pvcreate should be with units k|m|g
Line 707:     metadatasize = str(metadataSize) + 'm'
Line 708:     cmd = ["pvcreate", "--metadatasize", metadatasize, "metadacopies", "2", "--metadataignore"]
should be "metadatacopies" and not "metadacopies".
Line 709:     cmd.extend(devices)
Line 710: 
Line 711:     #pvcreate on a dev that is already a PV but not in a VG returns rc = 0.
Line 712:     #The device is created with the new parameters.


--
To view, visit http://gerrit.usersys.redhat.com/908
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib040902610fd2c5b0de04de95b57f0bfbdd1e11e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list