typo in BZ#736034 - Add metadataignore switch to pvcreate.
Dan Kenigsberg
danken at redhat.com
Mon Sep 19 17:14:57 UTC 2011
On Mon, Sep 19, 2011 at 02:16:07PM +0300, Haim Ateya wrote:
> Haim Ateya has posted comments on this change.
>
> Change subject: BZ#736034 - Add metadataignore switch to pvcreate.
> ......................................................................
>
>
> Patch Set 4: Fails
>
> (1 inline comment)
>
> please fix metdacopies to metadatacopies.
>
> ....................................................
> File vdsm/storage/lvm.py
> Line 704: def _initpvs(devices, metadataSize):
> Line 705: devices = _normalizeargs(devices)
> Line 706: # Size for pvcreate should be with units k|m|g
> Line 707: metadatasize = str(metadataSize) + 'm'
> Line 708: cmd = ["pvcreate", "--metadatasize", metadatasize, "metadacopies", "2", "--metadataignore"]
> should be "metadatacopies" and not "metadacopies".
> Line 709: cmd.extend(devices)
> Line 710:
> Line 711: #pvcreate on a dev that is already a PV but not in a VG returns rc = 0.
> Line 712: #The device is created with the new parameters.
Thanks for noticing this. If you fix this typo, does the patch deliver
its promisses?
More information about the vdsm-patches
mailing list