Change in vdsm[master]: Do not attempt to configure the iscsid service

abaron at redhat.com abaron at redhat.com
Wed Nov 23 21:17:50 UTC 2011


Ayal Baron has posted comments on this change.

Change subject: Do not attempt to configure the iscsid service
......................................................................


Patch Set 5: (1 inline comment)

Of course it does.  We now support:
1. iscsi-initator-utils upgrade changing the conf file if defaults have changed
2. Admin can easily change/maintain the file without our intervention and without needing to know anything ovirt specific

....................................................
File vdsm/storage/iscsi.py
Line 153:     if dRet != 0:
Then it's worth commenting that so that no one will move it in the future.

--
To view, visit http://gerrit.ovirt.org/305
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dc0cc114fcc660d8b6b35e6654dfb2592eeb000
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list